This repository was archived by the owner on Jan 25, 2023. It is now read-only.
Removed unintended changes from core/base.py #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes a lot of commented code and two unused functions: print_overloads and print_defns.
|
@reazulhoque do you know something about this code I want to remove? |
DrTodd13
approved these changes
Nov 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes a lot of commented code and two unused functions:
print_overloads()andprint_defns().I would like to minimize changes to Numba and make our changes as close as possible to release0.51 branch.
@DrTodd13 if this code is not important for you then I would like to remove it.